Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: split edHelp() into edSetHelp() #926

Merged
merged 1 commit into from
Jan 21, 2025
Merged

ed: split edHelp() into edSetHelp() #926

merged 1 commit into from
Jan 21, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 21, 2025

  • Previously edSetHelp() was a wrapper for edHelp(), but the code is clearer if H (toggle help) and h (show help) are defined in separate functions (the indirect call via wrapper function didn't provide any benefit)
  • While here, toggle $HelpMode with ! instead of ^ because it's a bit more obvious

@mknos
ed: split edHelp() into edSetHelp()
eb4c817 
* Previously edSetHelp() was a wrapper for edHelp(), but the code is clearer if H (toggle help) and h (show help) are defined in separate functions (the indirect call via wrapper function didn't provide any benefit)
* While here, toggle $HelpMode with ! instead of ^ because it's a bit more obvious
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 21, 2025
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 21, 2025 09:14 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12883652895

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12869211215: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jan 21, 2025
@briandfoy briandfoy merged commit f9614ab into briandfoy:master Jan 21, 2025
21 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Jan 21, 2025
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy