Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep 1.2.0 release #481

Merged
merged 1 commit into from
Jul 10, 2023
Merged

prep 1.2.0 release #481

merged 1 commit into from
Jul 10, 2023

Conversation

gthao313
Copy link
Member

Issue number:
#479

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@etungsten etungsten self-requested a review July 10, 2023 16:59
CHANGELOG.md Outdated
* Removed unnecessary dep on older "time" crate from chrono ([#415])
* Fixed metrics not working for ipv6 clusters ([#406])
* Makefile: refactors brupop-image target ([#418])
* Cargo: use env vars when calling cargo ([#461])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#461 has not been closed. Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have a stopgap solution to fix the issue, but eventually we will find another solution to replace it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the stop gap solution part of this release? Can you link the PR instead of the open issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, otherwise. the helm chart would not work. Sure, I'll replace the link to the PR.

Added

* Refactored deployment and yaml generation to use Helm templating ([#126])
* Improved time window to become cron expression based scheduler ([#343]), ([#428])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#428 has not been closed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root cause for this issue was we hadn't release new versions which contains the new features on dev branch, so users reported the errors about mismatch containers. @stmcginnis had a related PR which is about improvement. Once we have new version out, this issue will be closed.

@gthao313 gthao313 merged commit 5dd70a3 into bottlerocket-os:develop Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants