Merge pull request #715 from KCSesh/fix-image-pull-template

fix: rename image_pull_secrets to ImagePullSecrets
bottlerocket-os · Feb 4, 2025 · 4b47564 · 4b47564
2 parents 1979088 + c1c3e72
commit 4b47564
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -134,7 +134,7 @@ placement:
 #  --docker-username=AWS \
 #  --docker-password=$(aws --region us-west-2 ecr get-login-password) \
 #  --namespace=brupop-bottlerocket-aws
-#image_pull_secrets: |-
+#imagePullSecrets:
 #  - name: "brupop"
 
 # External load balancer setting.

diff --git a/deploy/charts/bottlerocket-update-operator/README.md b/deploy/charts/bottlerocket-update-operator/README.md
@@ -120,7 +120,7 @@ placement:
 #  --docker-username=AWS \
 #  --docker-password=$(aws --region us-west-2 ecr get-login-password) \
 #  --namespace=brupop-bottlerocket-aws
-#image_pull_secrets: |-
+#imagePullSecrets:
 #  - name: "brupop"
 
 # External load balancer setting.

diff --git a/deploy/charts/bottlerocket-update-operator/templates/agent-daemonset.yaml b/deploy/charts/bottlerocket-update-operator/templates/agent-daemonset.yaml
@@ -89,9 +89,9 @@ spec:
       topologySpreadConstraints:
         {{- tpl (toYaml .) $ | nindent 8 }}
       {{- end }}
-      {{- if ((.Values.image_pull_secrets)) }}
-      image_pull_secrets: 
-        {{ .Values.image_pull_secrets }}
+      {{- with .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml . | nindent 8 }}
       {{- end }}
       volumes:
         - hostPath:

diff --git a/deploy/charts/bottlerocket-update-operator/templates/controller-deployment.yaml b/deploy/charts/bottlerocket-update-operator/templates/controller-deployment.yaml
@@ -83,8 +83,8 @@ spec:
       {{- if .Values.placement.controller.priorityClassName }}
       priorityClassName: {{ .Values.placement.controller.priorityClassName | quote }}
       {{- end }}
-      {{ if ((.Values.image_pull_secrets)) }}
-      image_pull_secrets: 
-        {{ .Values.image_pull_secrets }}
-      {{ end }}
+      {{- with .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
       serviceAccountName: brupop-controller-service-account
diff --git a/deploy/charts/bottlerocket-update-operator/values.yaml b/deploy/charts/bottlerocket-update-operator/values.yaml
@@ -51,7 +51,7 @@ placement:
 #  --docker-username=AWS \
 #  --docker-password=$(aws --region us-west-2 ecr get-login-password) \
 #  --namespace=brupop-bottlerocket-aws
-#image_pull_secrets: |-
+#imagePullSecrets:
 #  - name: "brupop"
 
 # External load balancer setting.