Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply scikit-package v0.1.0 to cifkit - autoamtic docformatter, prettier, codespell #73

Merged
merged 10 commits into from
Jan 4, 2025

Conversation

bobleesj
Copy link
Owner

@bobleesj bobleesj commented Jan 4, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description (Screenshots, files, etc)

Use scikit-package version 0.1.0 for cifkit.

Checklist

  • Are the tests passing?
  • If it's a new feature, have tests been written?
  • Have you added the .rst news file?

Added to documentation?

  • README.md
  • Official documentation
  • Google Codelab
  • No documentation needed

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.29%. Comparing base (241c160) to head (d0200b4).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
tests/core/models/test_cif.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          35       36    +1     
  Lines        1403     1406    +3     
=======================================
+ Hits         1365     1368    +3     
  Misses         38       38           
Files with missing lines Coverage Δ
tests/conftest.py 91.66% <100.00%> (ø)
tests/core/coordination/test_composition.py 100.00% <100.00%> (ø)
tests/core/coordination/test_filter.py 100.00% <100.00%> (ø)
tests/core/coordination/test_geometry.py 100.00% <ø> (ø)
tests/core/coordination/test_site.py 100.00% <ø> (ø)
tests/core/data/test_radius_handler.py 100.00% <100.00%> (ø)
tests/core/models/test_cif_ensemble.py 100.00% <100.00%> (ø)
tests/core/occupancy/test_mixing.py 100.00% <100.00%> (ø)
tests/core/preprocessors/test_environment.py 100.00% <ø> (ø)
tests/core/preprocessors/test_format.py 100.00% <100.00%> (ø)
... and 7 more

@bobleesj bobleesj merged commit e5fd787 into main Jan 4, 2025
4 checks passed
@bobleesj bobleesj deleted the scikit-package branch January 4, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant