Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar per JOSS feedback, fix code example margin, remove reviews #68

Merged
merged 11 commits into from
Nov 10, 2024

Conversation

bobleesj
Copy link
Owner

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description (Screenshots, files, etc)

Fix grammar per JOSS feedback, fix code example margin, remove reviews

Checklist

  • Are the tests passing?
  • If it's a new feature, have tests been written?
  • Have you added the .rst news file?

Added to documentation?

  • README.md
  • Official documentation
  • Google Codelab
  • No documentation needed

@bobleesj bobleesj marked this pull request as ready for review November 10, 2024 16:45
@bobleesj bobleesj merged commit 9fb5139 into main Nov 10, 2024
4 checks passed
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (4f2cf05) to head (8029912).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          35       35           
  Lines        1403     1403           
=======================================
  Hits         1365     1365           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobleesj bobleesj deleted the joss-feedback branch November 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant