Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Materials Project, CCDC .cif files #47

Merged
merged 13 commits into from
Oct 27, 2024
Merged

Support Materials Project, CCDC .cif files #47

merged 13 commits into from
Oct 27, 2024

Conversation

bobleesj
Copy link
Owner

@bobleesj bobleesj commented Oct 27, 2024

Closes #31

Previously .cif files have not been when initialized via CifEnsemble. Apply pre-process and edit the .cif files before turning them into CIF objects.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (a2a6f99) to head (0e30bc7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   97.31%   97.29%   -0.03%     
==========================================
  Files          35       35              
  Lines        1415     1403      -12     
==========================================
- Hits         1377     1365      -12     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobleesj bobleesj changed the title Support Materials Project .cif files Support Materials Project, CCSD .cif files Oct 27, 2024
@bobleesj bobleesj changed the title Support Materials Project, CCSD .cif files Support Materials Project, CCCD .cif files Oct 27, 2024
@bobleesj bobleesj marked this pull request as ready for review October 27, 2024 14:58
@bobleesj bobleesj merged commit bc69d6e into main Oct 27, 2024
4 checks passed
@bobleesj bobleesj changed the title Support Materials Project, CCCD .cif files Support Materials Project, CCDC .cif files Oct 27, 2024
@bobleesj bobleesj deleted the fix-joss branch October 27, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingestion works with Cif but not CifEnsemble
2 participants