Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react module 2 updates #885

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

binaryberserker
Copy link

No description provided.

@binaryberserker binaryberserker marked this pull request as draft January 3, 2025 22:36
@binaryberserker binaryberserker self-assigned this Jan 3, 2025

<strong>Having issues with your local setup?</strong> See the solution in [StackBlitz](https://stackblitz.com/fork/github/bitovi/academy/tree/main/exercises/react-vite/02-setting-up-your-environment/02-solution?file=src/App.tsx) or [CodeSandbox](https://codesandbox.io/p/devbox/github/bitovi/academy/tree/main/exercises/react-vite/02-setting-up-your-environment/02-solution?file=src/App.tsx).

ERROR: Failed to resolve import "./assets/react.svg" from "src/App.tsx". Does the file exist?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d remove this before merging.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really just wanted to note it to come back to it later

ERROR: Failed to resolve import "./assets/react.svg" from "src/App.tsx". Does the file exist?

@@ -168,6 +171,12 @@ npm run test

and "No test files found" will be written to the console.

Note: may need to set execution policy if running on windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows -> Windows.

@@ -191,7 +200,7 @@ Remove these generated files that we won’t need. Some projects do need them, b
- `src/assets`
- `src/App.css`
- `tsconfig.node.json`
- `.eslintrc.cjs`
- `eslint.config.js`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and I see .eslintrc.cjs being created by the generator. Was it this different file for you? I wonder what would cause the difference.

Screenshot showing the .eslintrc.cjs file in the directory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya it created eslint.config.js for me, may need some more investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants