To me it now seems to work correctly and has additional features. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow either a single ticket or an RT::Tickets object and return an RT::Transactions object for all relevent tickets
| my $start = $date->AsString( Format => 'sql' ); | ||
|
|
||
| $date->Set( Format => 'unknown', Value => $args{end} ); | ||
| $date->AddSeconds(86399) if $date->AsString =~ /\b00:00:00\b/; |
There was a problem hiding this comment.
This changes to the end of the day instead of the beginning. Means it can match what happened on $end day, not just the day before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working at the Billing ActivityReport and found it would be much handier to be able to pass in an RT::Tickets object to RelevantTxns.
I also found that start and end didn't work like expected, so I added some code to fix that.