Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1543: Add live media to header - PRODUCTION #12239

Merged
merged 166 commits into from
Jan 15, 2025

Conversation

shayneahchoon
Copy link
Contributor

@shayneahchoon shayneahchoon commented Dec 15, 2024

Resolves JIRA WSTEAM1-1521
Resolves JIRA WSTEAM1-1542
Resolves JIRA WSTEAM1-1543

Overall changes

VERY IMPORTANT: Production video content will not work on test pages.

Adds live media to the header of a live page:
Screenshot 2024-12-15 at 11 59 40

Adds live tv media to the header of a live page:
Screenshot 2024-12-15 at 12 03 46

Code changes

  • Add a new liveMedia config for the MediaLoader component.
  • Adds a MediaLoader component to the Header of a live page.

Testing

  1. Go here: http://localhost.bbc.com:7081/mundo/live/c7dkx155e626t
  2. Storybook (note: media doesn't play) https://wsteam1-1521-live-video-front-end--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/pages-live-page--with-live-stream
  3. Storybook (example with guidance): https://wsteam1-1521-live-video-front-end--5d28eb3fe163f6002046d6fa.chromatic.com/iframe.html?globals=&args=&id=components-liveheadermedia--component-with-guidance

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@shayneahchoon shayneahchoon marked this pull request as ready for review January 15, 2025 10:04
@shayneahchoon shayneahchoon merged commit a3b716c into latest Jan 15, 2025
11 checks passed
@shayneahchoon shayneahchoon deleted the WSTEAM1-1521-LIVE-VIDEO-FRONT-END branch January 15, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants