Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Git commit hashes when building BlazeVersionData #7140

Closed
wants to merge 1 commit into from

Conversation

odisseus
Copy link
Contributor

@odisseus odisseus commented Dec 9, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #7133

Description of this change

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Dec 9, 2024
@tpasternak
Copy link
Contributor

Well, it's a blaze client version, I would prefer to keep it null.

@tpasternak
Copy link
Contributor

This way is just putting sort-of-a-random-number there which can backlash in future. Particularly because the order seems to matter (there is a method blazeClientIsAtLeastCl)

@odisseus
Copy link
Contributor Author

odisseus commented Dec 9, 2024

You are right, the commit prefixes have no particular order, so my code violates that expectation. We could try to find the latest tag, or the commit date, but there is no guarantee that they will be ordered either.

@odisseus odisseus closed this Dec 9, 2024
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants