Add ESLint

.eslintrc.js

@@ -0,0 +1,18 @@
+module.exports = {
+    "extends": "babel",
+    "plugins": [
+        "jest",
+        "jasmine",
+    ],
+    "rules": {
+        "indent": ["error", 4],
+        "quotes": ["error", "single"],
+        "max-len": "off",
+        "arrow-parens": "off",
+    },
+    "env": {
+        "node": true,
+        "jest": true,
+        "jasmine": true,
+    },
+};

package.json

@@ -10,7 +10,8 @@
     "package": "npm run clean && npm run build && npm run bundle",
     "test": "jest & npm run flow",
     "build": "babel src --out-dir dist --ignore __tests__",
-    "flow": "flow check"
+    "flow": "flow check",
+    "eslint": "eslint src/ --format=codeframe"
   },
   "author": "Andrew Levine",
   "license": "MIT",
@@ -22,6 +23,7 @@
   },
   "devDependencies": {
     "babel-cli": "^6.18.0",
+    "babel-eslint": "^7.1.1",
     "babel-plugin-transform-async-to-generator": "^6.22.0",
     "babel-plugin-transform-class-properties": "^6.19.0",
     "babel-plugin-transform-es2015-destructuring": "^6.19.0",
@@ -30,6 +32,11 @@
     "babel-plugin-transform-es2015-spread": "^6.8.0",
     "babel-plugin-transform-flow-strip-types": "^6.21.0",
     "babel-plugin-transform-object-rest-spread": "^6.20.2",
+    "eslint": "^3.18.0",
+    "eslint-config-babel": "^6.0.0",
+    "eslint-plugin-flowtype": "^2.30.3",
+    "eslint-plugin-jasmine": "^2.2.0",
+    "eslint-plugin-jest": "^19.0.1",
     "flow-bin": "^0.37.4",
     "jest": "^18.0.0"
   },

src/github.js

@@ -72,7 +72,7 @@ type IssueCommentParams = {
 // https://developer.github.com/v3/issues/comments/#delete-a-comment
 exports.deleteIssueComment = ({ id, owner, repo }: IssueCommentParams) => {
     return del(`/repos/${owner}/${repo}/issues/comments/${id}`);
-}
+};
 
 type IssueParams = {
     content: string;
@@ -90,4 +90,4 @@ exports.createIssueReaction = ({ content, number, owner, repo }: IssueParams) =>
         json: true,
         body: JSON.stringify({ content })
     }).then(({ body }) => body);
-}
+};

src/handlers/issue_comment/created.js

@@ -2,7 +2,7 @@
 
 import github from '../../github';
 import Logger from '../../logger';
-import { oneLine } from 'common-tags'
+import { oneLine } from 'common-tags';
 
 const { log } = new Logger('handlers/issue_comment/created.js');
 
@@ -46,7 +46,7 @@ const isAnnoying = (body) => body === '+1' || body === '-1';
 export default function({ comment, issue, repository }: IssueCommentPayload) {
 
     if (isAnnoying(comment.body.trim())) {
-        log(`Removing a +1/-1 comment`, 'verbose');
+        log('Removing a +1/-1 comment', 'verbose');
         github.deleteIssueComment({
             id: comment.id,
             owner: repository.owner.login,

src/handlers/issues/__tests__/labeled.js

@@ -1,7 +1,6 @@
 // @flow
 
 import handler from '../labeled';
-import fs from 'fs';
 
 const wrongLabelPayload = require('./__fixtures__/other-label-added.json');
 const needsInfoPayload = require('./__fixtures__/info-label-added.json');

src/handlers/issues/__tests__/opened.js

@@ -1,7 +1,6 @@
 // @flow
 
 import handler from '../opened';
-import fs from 'fs';
 
 const payload = require('./__fixtures__/new-issue-opened.json');
 jest.mock('../../../github', () => ({

src/handlers/issues/opened.js

@@ -27,11 +27,11 @@ export default function({ issue, repository }: OpenedIssuePayload) {
     return github.getUserOrgs(issueSubmitter).then(orgs => {
         const isBabelOrgMember = orgs.filter(({ login }) => login === 'babel').length;
         if (isBabelOrgMember) {
-            log(`User is member of Babel org. Skipping comment`, 'verbose');
+            log('User is member of Babel org. Skipping comment', 'verbose');
             return;
-        };
+        }
 
-        log(`User is not member of Babel org. Adding comment`, 'verbose');
+        log('User is not member of Babel org. Adding comment', 'verbose');
         return github.addIssueComment(issue.number, owner, repo, msg);
     }).catch(e => {
         log(`Failed attempting to add new issue comment. Details: ${e.message}`);

src/handlers/pull_request/opened.js

@@ -26,7 +26,8 @@ function issuesFromBody(body: string) {
     if (!fixedList) return [];
 
     const reID = /#(\d+)/g;
-    let val, ids = [];
+    let val = [];
+    const ids = [];
     while ((val = reID.exec(fixedList)) !== null) {
         ids.push(val[1]);
     }
@@ -39,7 +40,7 @@ export default function({ number, pull_request, repository }: OpenedPRPayload) {
     const issues = issuesFromBody(body);
     if (!issues.length) {
         log(`No issues found for PR #${number}`, 'verbose');
-        return
+        return;
     }
 
     const { name: repo, owner: { login } } = repository;
@@ -55,6 +56,6 @@ export default function({ number, pull_request, repository }: OpenedPRPayload) {
     Promise.all(requests).then(() => {
         log(`Submitted labels for PR ${number} on issues: ${issuesStr}`, 'verbose');
     }).catch(e => {
-        log(`Failed submitted labels for PR ${number} on at least one of ${issuesStr}`);
+        log(`Failed submitted labels for PR ${number} on at least one of ${issuesStr}. Details: ${e.message}`);
     });
 }

src/handlers/status/failure.js

@@ -47,7 +47,7 @@ const buildFailureMsg = (prOwner: string, failedBuilds: Array<JobItem>, owner, r
 };
 
 export default function(payload: FailedStatusPayload) {
-    const { repository: repo, target_url } = payload;
+    const { repository: repo } = payload;
     const [, buildID] = payload.target_url.match(reBuildID) || [];
 
     log(`Fetching test matrix for TravisCI build #${buildID}`, 'verbose');