Skip to content

Commit

Permalink
Solr v9.4.x compatibility (#80)
Browse files Browse the repository at this point in the history
  • Loading branch information
azagniotov authored Feb 12, 2024
1 parent 42aaa65 commit 7beb39d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ solrLuceneAnalyzerSudachiProjectGroup=io.github.azagniotov
solrLuceneAnalyzerSudachiProjectVersion=1.0.0-SNAPSHOT

sudachiVersion=0.7.3
solrVersion=9.3.0
luceneVersion=9.7.0
solrVersion=9.4.0
luceneVersion=9.8.0
slf4jVersion=1.7.36
log4j2Version=2.19.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ public void clear() {

@Override
public void reflectWith(AttributeReflector attributeReflector) {
attributeReflector.reflect(SudachiAttribute.class, "dictionary", getDictionary());
// AttributeReflector is used by Solr and Elasticsearch to provide analysis output.
//
// The following code:
// attributeReflector.reflect(SudachiAttribute.class, "dictionary", getDictionary());
//
// is commented out because we do not need to reflect on the Dictionary, it is not needed for the above.
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ public void clear() {
public void reflectWith(AttributeReflector attributeReflector) {
// AttributeReflector is used by Solr and Elasticsearch to provide analysis output.
//
// The following code is commented out because of:
// The following code:
// attributeReflector.reflect(SudachiMorphemeAttribute.class, "morpheme", getMorpheme());
//
// is commented out because of:
// 1. We do not need to reflect on Morpheme object implementation, it is not needed for the above.
// 2. The com.worksap.nlp.sudachi.MorphemeImpl has package default visibility. Solr throws because of that:
// Caused by: java.lang.IllegalAccessException: access violation: class com.worksap.nlp.sudachi.MorphemeImpl,
Expand Down

0 comments on commit 7beb39d

Please sign in to comment.