Fix bytesperline calculation for libcamera0.2 #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For libcamera0.2
configuration.stride
is already set to some incorrect value andconfigurations->validate()
doesn't update it if it's not 0.For libcamera0.1 it was set to 0. So set it to 0 manually to make sure
configurations->validate()
computes the correct value.Before:
After:
Tested both with libcamera0.1 and libcamera0.2 on raspberry pi 4. Errors are gone and streaming works fine with libcamera0.2 finally.
Thanks to @tom-ard for help with debugging.
Fixes #139