Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Concurrency Warnings in Swift 6 #310

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Fix Concurrency Warnings in Swift 6 #310

wants to merge 18 commits into from

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jan 7, 2025 •
edited
Loading

Fixes #185
Description of changes:
This PR fixes a bunch of Swift 6 errors (warnings for pre-Swift 6).

  • Marks a lot of our classes as unchecked Sendable; Swift cannot verify the Send-ability of these classes due to C pointers.
  • Refactors our tests to address some concurrency issues.
  • Marks the global allocator as unsafe, since Swift complains that global mutable things are not safe.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@waahm7 waahm7 changed the title WIP | Swift 6 Support Fix Concurrency Warnings in Swift 6 Jan 7, 2025
@waahm7 waahm7 marked this pull request as ready for review January 7, 2025 19:46
@waahm7 waahm7 requested a review from xiazhvera January 7, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiazhvera xiazhvera Awaiting requested review from xiazhvera

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of GCD in asynchronous context
1 participant
@waahm7