Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused test utils #5005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented Jan 8, 2025

Description of changes:

PQ implementations have been moved to AWS-LC, so this is no longer needed.

Testing:

All existing tests should pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jan 8, 2025
@jmayclin jmayclin requested review from jouho and maddeleine January 8, 2025 20:16
@jmayclin jmayclin marked this pull request as ready for review January 8, 2025 20:16
@@ -1,115 +0,0 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure more cleanup is needed. The s2n_testlib.h file also has some unused function definitions. Unsure if anything with the word "kat" in it needs to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants