Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint + format base repository directory #9171

Open
wants to merge 7 commits into
base: v2
Choose a base branch
from

Conversation

kdaily
Copy link
Member

@kdaily kdaily commented Dec 24, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily kdaily force-pushed the lint-format-base-repo-extended branch from 85022db to b1d5d66 Compare January 13, 2025 22:07
@kdaily kdaily changed the title Lint format base repo extended Lint format base repository directory Jan 21, 2025
@kdaily kdaily changed the title Lint format base repository directory Lint + format base repository directory Jan 21, 2025
@kdaily kdaily marked this pull request as ready for review January 23, 2025 21:48
@aemous aemous self-requested a review January 24, 2025 15:33
@aemous
Copy link
Contributor

aemous commented Feb 12, 2025

@kdaily Looks like there's merge conflicts. Can we get those resolved ?

@kdaily kdaily force-pushed the lint-format-base-repo-extended branch from b1d5d66 to fa16b3e Compare February 13, 2025 23:20
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handful of fixes, we may want to try running this with UP032 to automate some of the string cleanup.

@kdaily
Copy link
Member Author

kdaily commented Feb 14, 2025

Handful of fixes, we may want to try running this with UP032 to automate some of the string cleanup.

UP302 is enabled and will be run when I run ruff check; these changes are only for ruff format since they lines changed is large:

select = ["E4", "E7", "E9", "F", "I", "UP"]

kdaily and others added 2 commits March 6, 2025 11:29
Co-authored-by: Nate Prewitt <[email protected]>
@kdaily kdaily requested a review from nateprewitt March 7, 2025 03:07
kdaily and others added 2 commits March 7, 2025 10:12
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last one to fix and then I think you're good.

Co-authored-by: Nate Prewitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants