chore(eslint): enforce spacing at beginning of comments #33077
+365
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
aws-cdk-automation
previously requested changes
Jan 22, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33077/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
kaizencc
added
the
pr-linter/cli-integ-tested
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
|
No need to integ test as this touches comments only |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
kaizencc
commented
Jan 22, 2025
| @@ -363,7 +363,8 @@ integTest('doubly nested stack', | |||
| await fixture.cdkDeploy('with-doubly-nested-stack', { | |||
| captureStderr: false, | |||
| }); | |||
| })); | |||
| }), | |||
| ); | |||
There was a problem hiding this comment.
this is just a me fix :) plz don't make me pull it out into a separate PR
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
kaizencc
commented
Jan 22, 2025
packages/@aws-cdk-testing/framework-integ/test/aws-config/test/integ.rule.ts
Outdated
Show resolved
Hide resolved
kaizencc
commented
Jan 22, 2025
packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.client-vpn-endpoint.ts
Outdated
Show resolved
Hide resolved
kaizencc
commented
Jan 22, 2025
packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.instance.lit.ts
Outdated
Show resolved
Hide resolved
kaizencc
commented
Jan 22, 2025
...s-cdk-testing/framework-integ/test/aws-route53-targets/test/integ.api-gateway-domain-name.ts
Outdated
Show resolved
Hide resolved
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
kaizencc
commented
Jan 22, 2025
kaizencc
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
GavinZZ
approved these changes
Jan 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33077 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 224 224
Lines 13762 13762
Branches 2414 2414
=======================================
Hits 11220 11220
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforces spacing at beginning of comments. we are exempting situations that have
///because they are special comments that jsii recognizes, and situations that have////////to delineate a split of some sport.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license