chore(toolkit): rollback implementation and tests #33074
+120
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33074 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 224 224
Lines 13762 13762
Branches 2414 2414
=======================================
Hits 11220 11220
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-maintainer-review
kaizencc
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mrgrain
reviewed
Jan 23, 2025
| const result = await deployments.rollbackStack({ | ||
| stack, | ||
| roleArn: options.roleArn, | ||
| toolkitStackName: options.toolkitStackName, |
There was a problem hiding this comment.
Suggested change
| toolkitStackName: options.toolkitStackName, | |
| toolkitStackName: this.toolkitStackName, |
mrgrain
reviewed
Jan 23, 2025
Comment on lines
+44
to
+50
|
|
||
| /** | ||
| * Name of the toolkit stack to use/deploy | ||
| * | ||
| * @default CDKToolkit | ||
| */ | ||
| readonly toolkitStackName?: string; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Name of the toolkit stack to use/deploy | |
| * | |
| * @default CDKToolkit | |
| */ | |
| readonly toolkitStackName?: string; |
We have it on the toolkit
mrgrain
reviewed
Jan 23, 2025
| stack, | ||
| roleArn: options.roleArn, | ||
| toolkitStackName: options.toolkitStackName, | ||
| force: options.force, |
There was a problem hiding this comment.
Suggested change
| force: options.force, | |
| force: options.orphanFailedResources, |
mrgrain
reviewed
Jan 23, 2025
Comment on lines
+51
to
+57
|
|
||
| /** | ||
| * Whether to force the rollback or not | ||
| * | ||
| * @default false | ||
| */ | ||
| readonly force?: boolean; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Whether to force the rollback or not | |
| * | |
| * @default false | |
| */ | |
| readonly force?: boolean; |
should be the same as orphanFailedResources
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces rollback to the programatic toolkit, plus tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license