Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw ValidationError instead of untyped errors in L1s #33032

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 21, 2025

Issue

All L1s for #32569

Description of changes

Updated the codegen to throw the correct error.
Instead of

throw new Error("Unexpected IResolvable");

we now throw

throw new errors.ValidationError("Unexpected IResolvable", scope);

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Existing tests. Exemptions granted as this is basically a refactor of existing code.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-codecov The PR linter will not require codecov checks to pass labels Jan 21, 2025
@github-actions github-actions bot added the p2 label Jan 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2025 13:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2025
@mrgrain mrgrain changed the title feat: use ValidationError in L1s feat: throw ValidationError instead of untyped errors in L1s Jan 21, 2025
kaizencc
kaizencc previously approved these changes Jan 21, 2025
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but i assume you'll want to wait until s3/validation-error is merged?

Base automatically changed from mrgrain/fix/s3/validation-error to main January 21, 2025 16:46
@mrgrain mrgrain requested a review from a team as a code owner January 21, 2025 16:46
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a08e441
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (61e876b) to head (a08e441).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33032   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files         224      224           
  Lines       13755    13755           
  Branches     2413     2413           
=======================================
  Hits        11209    11209           
  Misses       2273     2273           
  Partials      273      273           
Flag Coverage Δ
suite.unit 81.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.85% <ø> (ø)
packages/aws-cdk-lib/core 82.15% <ø> (ø)

@mrgrain mrgrain marked this pull request as draft January 21, 2025 17:26
@mrgrain mrgrain dismissed kaizencc’s stale review January 21, 2025 17:27

This will need more changes. Dismissing review to force a re-review later.

@mrgrain
Copy link
Contributor Author

mrgrain commented Jan 21, 2025

Drafting the PR. This clearly needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-codecov The PR linter will not require codecov checks to pass pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants