Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rds): fix typos #33006

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/aws-cdk-lib/aws-ec2/lib/security-group.ts
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ export class SecurityGroup extends SecurityGroupBase {
* Look up a security group.
*/
private static fromLookupAttributes(scope: Construct, id: string, options: SecurityGroupLookupOptions) {
if (Token.isUnresolved(options.securityGroupId) || Token.isUnresolved(options.securityGroupName) || Token.isUnresolved(options.vpc?.vpcId)) {
if (Token.isUnresolved(options.securityGroupId) || Token.isUnresolved(options.securityGroupName) || Token.isUnresolved(options.vpc?.vpcId)) {
throw new Error('All arguments to look up a security group must be concrete (no Tokens)');
}

Expand Down Expand Up @@ -515,8 +515,8 @@ export class SecurityGroup extends SecurityGroupBase {
this.securityGroup = new CfnSecurityGroup(this, 'Resource', {
groupName: this.physicalName,
groupDescription,
securityGroupIngress: Lazy.any({ produce: () => this.directIngressRules }, { omitEmptyArray: true } ),
securityGroupEgress: Lazy.any({ produce: () => this.directEgressRules }, { omitEmptyArray: true } ),
securityGroupIngress: Lazy.any({ produce: () => this.directIngressRules }, { omitEmptyArray: true }),
securityGroupEgress: Lazy.any({ produce: () => this.directEgressRules }, { omitEmptyArray: true }),
vpcId: props.vpc.vpcId,
});

Expand Down Expand Up @@ -552,7 +552,7 @@ export class SecurityGroup extends SecurityGroupBase {
// In the case of "allowAllOutbound", we don't add any more rules. There
// is only one rule which allows all traffic and that subsumes any other
// rule.
if (!remoteRule) { // Warn only if addEgressRule() was explicitely called
if (!remoteRule) { // Warn only if addEgressRule() was explicitly called
Annotations.of(this).addWarningV2('@aws-cdk/aws-ec2:ipv4IgnoreEgressRule', 'Ignoring Egress rule since \'allowAllOutbound\' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup');
}
return;
Expand All @@ -567,7 +567,7 @@ export class SecurityGroup extends SecurityGroupBase {
// In the case of "allowAllIpv6Outbound", we don't add any more rules. There
// is only one rule which allows all traffic and that subsumes any other
// rule.
if (!remoteRule) { // Warn only if addEgressRule() was explicitely called
if (!remoteRule) { // Warn only if addEgressRule() was explicitly called
Annotations.of(this).addWarningV2('@aws-cdk/aws-ec2:ipv6IgnoreEgressRule', 'Ignoring Egress rule since \'allowAllIpv6Outbound\' is set to true; To add customized rules, set allowAllIpv6Outbound=false on the SecurityGroup');
}
return;
Expand Down Expand Up @@ -653,7 +653,7 @@ export class SecurityGroup extends SecurityGroupBase {
const description = this.allowAllOutbound ? ALLOW_ALL_RULE.description : MATCH_NO_TRAFFIC.description;
super.addEgressRule(peer, port, description, false);
} else {
const rule = this.allowAllOutbound? ALLOW_ALL_RULE : MATCH_NO_TRAFFIC;
const rule = this.allowAllOutbound ? ALLOW_ALL_RULE : MATCH_NO_TRAFFIC;
this.directEgressRules.push(rule);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-rds/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ new rds.ServerlessClusterFromSnapshot(this, 'Cluster', {

You can access your Aurora DB cluster using the built-in Data API. The Data API doesn't require a persistent connection to the DB cluster. Instead, it provides a secure HTTP endpoint and integration with AWS SDKs.

The following example shows granting Data API access to a Lamba function.
The following example shows granting Data API access to a Lambda function.

```ts
declare const vpc: ec2.Vpc;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export interface ServerlessV2ClusterInstanceProps extends ClusterInstanceOptions
*
* For serverless v2 instances this means:
* - true: The serverless v2 reader will scale to match the writer instance (provisioned or serverless)
* - false: The serverless v2 reader will scale with the read workfload on the instance
* - false: The serverless v2 reader will scale with the read workload on the instance
*
* @default false
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/aws-rds/lib/instance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export enum LicenseModel {
LICENSE_INCLUDED = 'license-included',

/**
* Bring your own licencse.
* Bring your own license.
*/
BRING_YOUR_OWN_LICENSE = 'bring-your-own-license',

Expand Down Expand Up @@ -1355,7 +1355,7 @@ export class DatabaseInstanceReadReplica extends DatabaseInstanceNew implements
}

// The read replica instance always uses the same engine as the source instance
// but some CF validations require the engine to be explicitely passed when some
// but some CF validations require the engine to be explicitly passed when some
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar typo in security-group up for grab

// properties are specified.
const shouldPassEngine = props.domain != null;

Expand Down
Loading