Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various todo.jsm features #12

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added various todo.jsm features #12

wants to merge 9 commits into from

Conversation

mcpower
Copy link

@mcpower mcpower commented Dec 21, 2014

how do i javascript.
Some things may not be coded well, but I guess I haven't seen calc.js yet.

Review on Reviewable

e.reply(list.join("; "));
var i = 0;
e.reply(list.map(function addIndex(todo) {
return "[{0}] {1}".format(i++, todo);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Array.map's second argument

@mcpower
Copy link
Author

mcpower commented Dec 25, 2014

d6d59f7 should fix everything @auscompgeek was talking about, unless I missed a bra—

NOTE: has been barely tested.
@auscompgeek auscompgeek added ready and removed ready labels Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants