Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin version of Appsmith in chart to avoid surprise upgrades #38714

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

wyattwalter
Copy link

@wyattwalter wyattwalter commented Jan 16, 2025

Description

Pin the version of Appsmith deployed by the chart with the version that was tested when the chart was published.

Fixes #38713

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Deployment Updates
    • Updated Helm chart version to 3.6.1
    • Updated application version to 1.57
    • Modified image tag configuration to use chart's app version as default

Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

Walkthrough

The pull request focuses on modifying the Helm chart configuration to pin the Appsmith version by default. Changes were made to three files in the deploy/helm directory: Chart.yaml, templates/deployment.yaml, and values.yaml. The primary goal is to prevent unexpected automatic updates by changing how the image tag is retrieved and referenced during deployment.

Changes

File Change Summary
deploy/helm/Chart.yaml - appVersion updated from 1.56 to 1.57
- version updated from 3.6.0 to 3.6.1
deploy/helm/templates/deployment.yaml - Modified image tag retrieval to use .Chart.AppVersion as default
deploy/helm/values.yaml - Changed image tag from "latest" to ""

Assessment against linked issues

Objective Addressed Explanation
Pin Appsmith version by default [#38713]
Reduce surprising upgrade behavior

Suggested Labels

skip-changelog

Suggested Reviewers

  • sharat87
  • ApekshaBhosale
  • nidhi-nair

Poem

🚢 Helm charts sailing smooth and bright,
No more surprises in deployment's might
Version pinned with careful grace
Upgrades now happen at our pace
Kubernetes sails with calm delight! 🌊


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1963a9a and 5e209f0.

📒 Files selected for processing (3)
  • deploy/helm/Chart.yaml (2 hunks)
  • deploy/helm/templates/deployment.yaml (1 hunks)
  • deploy/helm/values.yaml (1 hunks)
🔇 Additional comments (3)
deploy/helm/Chart.yaml (1)

4-4: Version updates look good!

The version bumps follow semantic versioning principles and align with the PR objective of pinning versions.

Also applies to: 15-15

deploy/helm/templates/deployment.yaml (1)

95-95: Good change for version stability!

Using .Chart.AppVersion as the default instead of "latest" effectively pins the version and prevents surprise upgrades.

deploy/helm/values.yaml (1)

137-137: Verify the tag override behavior.

The comment above suggests this value overrides the chart's appVersion, but we're setting it to empty string. Let's verify this behaves as expected across different Helm versions.

✅ Verification successful

Empty tag correctly falls back to Chart.AppVersion

The empty tag value in values.yaml allows the deployment to use Chart.AppVersion as the image tag, which is the intended behavior.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the image tag resolution logic in the template
helm template . --debug | grep -A 5 "image:"

Length of output: 139


Script:

#!/bin/bash
# Find deployment template files
fd deployment.yaml

# Once found, inspect the template logic
cat deploy/helm/templates/deployment.yaml

Length of output: 8757


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: pin Appsmith version in the Helm chart by default
1 participant