Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] flink env check improvement #3469

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[Improve] flink env check improvement #3469

merged 4 commits into from
Jan 9, 2024

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Jan 8, 2024

[Improve] flink env check improvement


/* this add/update operation ok */
OK(0),

/* defined flink name repeated */
/** name repeated */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 / * name repeated */

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit bff3876 into dev Jan 9, 2024
7 of 8 checks passed
@wolfboys wolfboys deleted the flink-env branch January 11, 2024 15:57
zzzk1 pushed a commit to zzzk1/incubator-streampark that referenced this pull request Jan 12, 2024
* [Improve] flink env check improvement

* minor improve

* [Improve] check flink env improvement

* Update FlinkEnvCheckEnum.java

---------

Co-authored-by: benjobs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants