-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] User can use different hadoop-user to submit application #3401
Conversation
Overall, it looks good 👍 Keep up the good work! I'm really looking forward to seeing the next update. 😊 |
@wolfboys I think the key changes are in YarnApplicationClient class, setConfig method directly using UserGroupInformation.setLoginUser method is not correct, should use ProxyUser, This requires either changing the doSubmit method declaration or moving the setConfig changes into the doSubmit method. And config the hadoop-user's keytab on the job definition page is required in a Kerberos-enabled environment too. |
@wolfboys Do you have any suggestions for this? |
If Kerberos is involved, things will become complicated. How to manage the Kerberos configurations for different users is a problem we have to face. I suggest not considering Kerberos for now. |
@wolfboys The code has been modified to use proxyuser |
Thanks for your contribution, I will review it later |
You can modify your title, for example [Feature] User can use different hadoop-user to submit application, the first letter is preferably capitalized, thank you |
The hadoopUser also needs to be set in the application copy method |
One more question, have you tested it? Will the set hadoopUser work ok? |
I've tested it against streampark 2.1.2 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job🤗
What changes were proposed in this pull request
Issue Number: close #3222
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts