Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2024-53677 #145

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

loganaden
Copy link

No description provided.

Co-authored-by: Devraj "Kushal" Appadu <[email protected]>
Co-authored-by: Jaykishan Mutkawoa <[email protected]>
Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change 1) Roller starts but returns 500 error on request and 2) The Selenium tests fail. I may be wrong about this, but I think migrating to Struts 6 is going to be take a bit more effort.

<struts.version>2.5.29</struts.version> <!-- .30+ breaks selenium tests -->
<struts.version>6.4.0</struts.version> <!-- .30+ breaks selenium tests -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment next to it means that any update beyond .30 will require reading the struts migration guide and resolve problems since the very next release has breaking changes in some areas.

@mbien mbien marked this pull request as draft January 10, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants