Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optee-utee: support no-std net. #164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ivila
Copy link
Contributor

@ivila ivila commented Jan 20, 2025

  1. make optee_utee::net::{TcpStream, UdpSocket} support no-std
  2. update tcp_client-rs and udp_socket-rs to support running at no-std

Fixes #162

@ivila ivila force-pushed the feat_noStdNet_zc branch 2 times, most recently from b7c5ef7 to c2ac250 Compare January 21, 2025 08:23
Copy link
Contributor

@DemesneGH DemesneGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, please also update the no-std part in: https://github.com/apache/incubator-teaclave-trustzone-sdk?tab=readme-ov-file#supported-examples

Except for these small recommendations, the PR looks great to me. Feel free to add the tag once they’re addressed. Thanks!

Reviewed-by: Yuan Zhuang <[email protected]>

examples/tcp_client-rs/ta/src/main.rs Outdated Show resolved Hide resolved
examples/tcp_client-rs/ta/src/main.rs Show resolved Hide resolved
- introduce the Socket struct for performing socket operations within TEE.
- introduce the SocketAdapter trait to support various implementations of the
  GP TEE Sockets API.
- introduce a predefined optee module for TCP and UDP support in OP-TEE
  compatible TEE OS.

Signed-off-by: ivila <[email protected]>
Reviewed-by: Yuan Zhuang <[email protected]>
@ivila ivila force-pushed the feat_noStdNet_zc branch 2 times, most recently from c18b1cc to eb36c29 Compare January 23, 2025 06:02
- add ipv6 call in tcp_client-rs and udp_socket-rs
- enable no_std run of tcp_client-rs and udp_socket-rs in ci

Signed-off-by: ivila <[email protected]>
Reviewed-by: Yuan Zhuang <[email protected]>
@ivila
Copy link
Contributor Author

ivila commented Jan 26, 2025

Force update for ipv6 test and some comments. There are some more changes in those files:

  1. ci/ci.sh: move tcp_client-rs and udp_client-rs out of STD only.
  2. tests/optee-qemuv8.sh: Enable the network, no matter the environment.
  3. examples/tcp_client-rs: add ipv6 test.
  4. examples/udp_client-rs: add ipv6 test.

@ivila ivila requested review from DemesneGH and b49020 January 26, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: optee-utee: support no-std net.
3 participants