Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acipher main.rs: Fix arg validation error messages #134

Merged
merged 1 commit into from
May 22, 2024

Conversation

msgilligan
Copy link
Contributor

@msgilligan msgilligan commented May 21, 2024

  • Subtract 1 from args.len() to get the number of arguments (arg[0] is program path/name)
  • Improve the "Correct usage" string to show a (more) standard synopsis
  • Improve the message when key size < 256 is specified.

Signed-off-by: Sean Gilligan [email protected]

@msgilligan msgilligan force-pushed the msgilligan/acipher-rs-fix-args branch from fc82c21 to 26d176b Compare May 21, 2024 02:55
@msgilligan msgilligan marked this pull request as ready for review May 21, 2024 02:56
@b49020
Copy link
Contributor

b49020 commented May 21, 2024

Reviewed-by: Sumit Garg <[email protected]>

@DemesneGH
Copy link
Contributor

Reviewed-by: Yuan Zhuang <[email protected]>

@DemesneGH
Copy link
Contributor

Ready to merge. @msgilligan Could you add the two tags above in commit message? thanks!

Signed-off-by: Sean Gilligan <[email protected]>
Reviewed-by: Sumit Garg <[email protected]>
Reviewed-by: Yuan Zhuang <[email protected]>
@msgilligan msgilligan force-pushed the msgilligan/acipher-rs-fix-args branch from 26d176b to b15f3be Compare May 22, 2024 02:25
@msgilligan
Copy link
Contributor Author

Ready to merge. @msgilligan Could you add the two tags above in commit message? thanks!

Done! Thank you!

@DemesneGH DemesneGH merged commit 1a25772 into apache:no-std May 22, 2024
@msgilligan msgilligan deleted the msgilligan/acipher-rs-fix-args branch May 22, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants