[no-std branch] An effort to standardize OP-TEE rust based TAs development environment #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default feature remains std support, no_std can be enabled optionally. Signed-off-by: Sumit Garg <[email protected]>
Default feature remains std support, no_std can be enabled optionally. Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
Drop Box corresponding to the handle which has been freed to avoid following warning: warning: unused return value of `Box::<T>::from_raw` that must be used Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
As of now rust ring crate don't support no_std, so drop that support from TA. mbedtls can be a good alternative supporting no_std if we really need to use a separate user-space library. But here since GP TEE APIs already provides signature/verification APIs so that instead. Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
While at it drop redundant Cargo.lock Signed-off-by: Sumit Garg <[email protected]>
In no_std environment we have to explicitly link against libutils provided by OP-TEE. Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
Along with that drop global .cargo/config and move linker specific configuration to TA build.rs file and Makefile. This allows TA directory to be self sufficient to build up corresponding TA binary. Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
Having copies of TA linker scripts for every TA written in rust isn't scalable and prone to version skews with the linker script provided by TA devkit. And we would like to build and run TAs with different OP-TEE versions. So lets reuse linker script provided by TA devkit and therby drop copies from every TA direcetory. Signed-off-by: Sumit Garg <[email protected]>
This will allow us to upgrade toolchain for non_std TAs while keeping std TAs tied to a fixed nightly release until corresponding rust toolchain target lands upstream. Signed-off-by: Sumit Garg <[email protected]>
Upgrade rust toolchain to use nightly-2023-12-18 release. Signed-off-by: Sumit Garg <[email protected]>
Only no_std mode is supported with latest nightly, so build it for the time being. Signed-off-by: Sumit Garg <[email protected]>
As std TA examples have a dependency on downstream rust toolchain target which is cumbersome to maintain alongside, so instead drop them for now. Once the std target becomes fully upstream then we can add them again. Signed-off-by: Sumit Garg <[email protected]>
Downstream OP-TEE toolchain is not needed to no_std TAs, hence drop it. Along with that drop xargo support as we no longer require custom sysroot setup for TAs to be built under no_std environment. Signed-off-by: Sumit Garg <[email protected]>
Signed-off-by: Sumit Garg <[email protected]>
b49020
changed the title
|
All the CI checks passed with OP-TEE/build#714 already merged. |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details please refer to: #114. The CI should pass with OP-TEE/build#714 OP-TEE build PR included.
@DemesneGH @Sword-Destiny @jbech-linaro @jenswi-linaro @jforissier @etienne-lms @daniel-thompson @Ablu Fyi..
Feedback/comments are very much welcome, thanks.