Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-27831: Set hive.cbo.fallback.strategy to NEVER by default #5618

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ramesh0201
Copy link
Contributor

What changes were proposed in this pull request?

Remove TEST strategy since we want to uncover and fix as many CBO problems as possible.
Remove explicit set of hive.cbo.fallback.strategy to NEVER which is now the default.

Why are the changes needed?

A step towards making CBO work for all queries and the default behavior

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

Running all the test files modified

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but some test files need to be updated.

@zabetak
Copy link
Member

zabetak commented Jan 22, 2025

I pushed 8752bd3 to update the remaining .q.out files.

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests!

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants