-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28033: Fix TestMapJoinOperator to run on Tez #5615
Conversation
Quality Gate passedIssues Measures |
LGTM +1 (non-binding) |
LGTM, +1 |
@difin can you merge if the PR is okay |
@okumin Can you help with review and merging this PR |
I confirmed this part is applied only to Tez and that's why. hive/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java Lines 524 to 534 in eaa8189
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks @okumin @Aggarwal-Raghav @difin for the review |
…umathi Muthumurugesh, reviewed by Raghav Aggarwal, Dmitriy Fingerman, Shohei Okumiya)
What changes were proposed in this pull request?
The configuration for HIVE_DEFAULT_NULLS_LAST is set to false when Tez is used. The change ensures compatibility with Tez and proper null handling during serialization.
Why are the changes needed?
With MapReduce (MR), SERIALIZATION_NULL_SORT_ORDER is not set, hence the default null sorting is NULL FIRST. For Tez, the null sorting needed to be adjusted to prevent EOFException and ensure correct test execution with the generated data.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Test case