Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5956] feat(auth): Uses chain authorization to support Hive and HDFS #6100

Merged
merged 12 commits into from
Jan 8, 2025
Merged

[#5956] feat(auth): Uses chain authorization to support Hive and HDFS #6100

merged 12 commits into from
Jan 8, 2025

Conversation

xunliu
Copy link
Member

@xunliu xunliu commented Jan 5, 2025 •
edited
Loading

What changes were proposed in this pull request?

  1. Fixed some incorrect variable names.
  2. Make findManagedPolicy() and wildcardSearchPolies() an abstract functions.
  3. Supports CreateSchema privilege in the Chained Ranger Hive and Ranger HDFS

Why are the changes needed?

Fix: #5956

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Added ITs.

@xunliu xunliu requested review from theoryxu, jerqi and yuqi1129 January 5, 2025 14:19
@xunliu xunliu self-assigned this Jan 5, 2025
yuqi1129
yuqi1129 reviewed Jan 6, 2025
View reviewed changes
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
yuqi1129
yuqi1129 reviewed Jan 6, 2025
View reviewed changes
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Outdated Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Show resolved Hide resolved
...r/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java Show resolved Hide resolved
.../main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHadoopSQLPlugin.java Outdated Show resolved Hide resolved
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java Outdated Show resolved Hide resolved
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java Outdated Show resolved Hide resolved
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java Outdated Show resolved Hide resolved
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java Outdated Show resolved Hide resolved
core/src/main/java/org/apache/gravitino/hook/FilesetHookDispatcher.java Show resolved Hide resolved
@jerqi
Copy link
Contributor

jerqi commented Jan 7, 2025

Generally looks to me. Let @yuqi1129 take an another look.

@xunliu
Copy link
Member Author

xunliu commented Jan 8, 2025

@yuqi1129 I fixed all the problem, please help me review again. Thanks.

yuqi1129
yuqi1129 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jan 8, 2025

@xunliu do you have any further comments regarding this PR?

@yuqi1129 yuqi1129 merged commit 2625634 into apache:main Jan 8, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerqi jerqi jerqi left review comments

@FANNG1 FANNG1 FANNG1 left review comments

@yuqi1129 yuqi1129 yuqi1129 approved these changes

@theoryxu theoryxu Awaiting requested review from theoryxu

Assignees

@xunliu xunliu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] Use chain authorization to support Hive and HDFS authorization
4 participants
@xunliu @jerqi @yuqi1129 @FANNG1