Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5957] feat(CLI): Table format output for SchemaDetails command #5975

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

waukin
Copy link
Contributor

@waukin waukin commented Dec 24, 2024

What changes were proposed in this pull request?

Support table format output for SchemaDetails command.

Why are the changes needed?

Issue: #5957

Does this PR introduce any user-facing change?

No.

How was this patch tested?

gcli schema details --name <schema_name> -m <metalake_name>
gcli schema details --name <schema_name> -m <metalake_name> --output plain
gcli schema details --name <schema_name> -m <metalake_name> --output table

@waukin waukin marked this pull request as draft December 24, 2024 13:20
@xunliu xunliu requested a review from justinmclean December 26, 2024 02:21
@Override
public void output(Schema schema) {
System.out.println(schema.name() + "," + schema.comment());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the null check of the previous code. As per more recent PRs, it should also output "No schemas exist." if there are none.

@waukin waukin force-pushed the feature/schema_details_table_format_output branch from d1a2d27 to a1d05b6 Compare December 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants