Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition for uploading artifacts in worker.yml #17708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Akshat-Jain
Copy link
Contributor

@Akshat-Jain Akshat-Jain commented Feb 8, 2025

Description

The if: ${{ failure() }} || ${{ inputs.artifact_prefix != '' }} condition in always seems to be evaluating to true, as can be seen here where the upload artifact step was run even though no prior step failed: https://github.com/implydata/druid/actions/runs/13199722965/job/36850130824?pr=3053

This is also the reason why this job failed on the weekly cron: https://github.com/apache/druid/actions/runs/13211720628/job/36886496050

This PR fixes it.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added the GHA label Feb 8, 2025
@Akshat-Jain Akshat-Jain requested a review from kgyrtkirk February 8, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant