Fix condition for uploading artifacts in worker.yml #17708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
if: ${{ failure() }} || ${{ inputs.artifact_prefix != '' }}
condition in always seems to be evaluating totrue
, as can be seen here where the upload artifact step was run even though no prior step failed: https://github.com/implydata/druid/actions/runs/13199722965/job/36850130824?pr=3053This is also the reason why this job failed on the weekly cron: https://github.com/apache/druid/actions/runs/13211720628/job/36886496050
This PR fixes it.
This PR has: