Fixing logging in supervisor. #17702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Feb 7, 2025
| @@ -1692,12 +1692,11 @@ public void runInternal() | |||
| // if suspended, ensure tasks have been requested to gracefully stop | |||
| if (stateManager.getSupervisorState().getBasicState().equals(SupervisorStateManager.BasicState.STOPPING)) { | |||
| // if we're already terminating, don't do anything here, the terminate already handles shutdown | |||
| log.info("[%s] supervisor is already stopping.", dataSource); | |||
| log.debug("[%s] supervisor is already stopping.", dataSource); | |||
There was a problem hiding this comment.
Suggested change
| log.debug("[%s] supervisor is already stopping.", dataSource); | |
| log.debug("Supervisor[%s] is already stopping.", dataSource); |
| } else if (stateManager.isIdle()) { | ||
| log.info("[%s] supervisor is idle.", dataSource); | ||
| log.debug("[%s] supervisor is idle.", dataSource); |
There was a problem hiding this comment.
Suggested change
| log.debug("[%s] supervisor is idle.", dataSource); | |
| log.debug("Supervisor[%s] is idle.", dataSource); |
| } else if (!spec.isSuspended()) { | ||
| log.info("[%s] supervisor is running.", dataSource); | ||
|
|
||
| log.debug("[%s] supervisor is running.", dataSource); |
There was a problem hiding this comment.
Suggested change
| log.debug("[%s] supervisor is running.", dataSource); | |
| log.debug("Supervisor[%s] is running.", dataSource); |
| @@ -3718,7 +3717,15 @@ && computeTotalLag() == 0) { | |||
| if (!idle) { | |||
| stateManager.maybeSetState(SupervisorStateManager.BasicState.RUNNING); | |||
| } else if (!stateManager.isIdle() && idleTime > idleConfig.getInactiveAfterMillis()) { | |||
| log.info("Setting supervisor[%s] to state[%s]", supervisorId, SupervisorStateManager.BasicState.IDLE.name()); | |||
There was a problem hiding this comment.
Would just this suffice?
Suggested change
| log.info("Setting supervisor[%s] to state[%s]", supervisorId, SupervisorStateManager.BasicState.IDLE.name()); | |
| log.info("Setting supervisor[%s] to idle"); |
There was a problem hiding this comment.
It could but I like the original message better :).
kfaraz
reviewed
Feb 7, 2025
| stateManager.maybeSetState(SeekableStreamSupervisorStateManager.SeekableStreamState.CREATING_TASKS); | ||
| createNewTasks(); | ||
| } else { | ||
| log.info("[%s] supervisor is suspended.", dataSource); | ||
| log.info("Supervisor for datasource[%s] is suspended.", dataSource); |
There was a problem hiding this comment.
Had you intended to make this log debug too?
There was a problem hiding this comment.
I did not earlier but now I do :)
kfaraz
approved these changes
Feb 7, 2025
kfaraz
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlord logs the status of each supervisor every second. So if we have 1000 supervisor, we log 1000 lines per second which seems redundant.
Adjusted the log levels to debug for these status logs.