-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Release datafusion-python 45 #1024
base: main
Are you sure you want to change the base?
Conversation
…n the python version
… single partition, so update the unit test to check all partitions.
This reverts commit b48d587.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i verified by running tests locally
source .venv/bin/activate
maturin develop --uv
python -m pytest
Cargo.toml
Outdated
@@ -17,7 +17,7 @@ | |||
|
|||
[package] | |||
name = "datafusion-python" | |||
version = "44.0.0" | |||
version = "45.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the patch release on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, unfortunately there is a restriction on the way we currently use test-pypi that has trouble with the release candidate versions. I proposed a discussion in the discord channel about it. I think there is a way we could do release candidates but there is a caveat in that I'd have to make one additional change from approval -> release
# there should be no more batches | ||
with pytest.raises(StopIteration): | ||
stream.next() | ||
rows_returned = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thank you! This is the issue i was facing in #1010 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and it's super odd. I have two different computers and on one it passed every time. On the other, it failed every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the latest commit (639e2ab
) for this PR is used for the RC. Should we merge this PR to main?
I'll merge it to main once the release is approved. I put this in draft to avoid it getting merged ahead of time. |
Which issue does this PR close?
This is to release DataFusion Python 45.
Rationale for this change
Next release