Skip to content

v0.22.2
Compare
Choose a tag to compare
@github-actions github-actions released this 07 Oct 16:30
· 5 commits to refs/heads/main since this release
v0.22.2
adeb5cd
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

🐛 Bug Fixes

upd: aws-anyscale-s3-policy module to support custom policies @brent-anyscale (#54)

The custom policies were not being passed from the root module to the sub-module. This change adds the ability to pass in custom modules from the root module.

This may replace the existing S3 Policy on the Anyscale S3 bucket

Additional updates include a large rewrite of the s3-policy module to include:

  • Pre-defined S3 Policy template file
  • Renamed variables to be more descriptive
  • Reworked examples/tests

Lastly, this also includes an updated kitchensink example to show how to use the custom policy feature.

On branch brent/update-s3policy
Changes to be committed:
modified: .pre-commit-config.yaml
modified: README.md
modified: examples/anyscale-v2-kitchensink/README.md
modified: examples/anyscale-v2-kitchensink/main.tf
modified: examples/anyscale-v2-kitchensink/variables.tf
modified: main.tf
modified: modules/aws-anyscale-s3-policy/README.md
deleted: modules/aws-anyscale-s3-policy/examples/README.md
modified: modules/aws-anyscale-s3-policy/examples/main.tf
modified: modules/aws-anyscale-s3-policy/examples/outputs.tf
modified: modules/aws-anyscale-s3-policy/examples/variables.tf
modified: modules/aws-anyscale-s3-policy/main.tf
new file: modules/aws-anyscale-s3-policy/predefined_s3_policy.tpl
modified: modules/aws-anyscale-s3-policy/test/README.md
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/main.tf
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/outputs.tf
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/variables.tf
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/versions.tf
modified: modules/aws-anyscale-s3-policy/variables.tf

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

This may replace the S3 policy on the existing S3 bucket

Contributors

brent-anyscale
Assets 2
Loading