ci: Fix edge case with Nightly builds right after new release #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxymVlasov
commented
Jan 22, 2025
yermulnik
approved these changes
Jan 22, 2025
Comment on lines
+338
to
+341
| run: >- | ||
| git tag --points-at HEAD | ||
| | | ||
| xargs git tag --delete |
There was a problem hiding this comment.
What's the point in wrapping this one-liner to multiline?
For me it looks odd when split to three lines 🤷🏻
Suggested change
| run: >- | |
| git tag --points-at HEAD | |
| | | |
| xargs git tag --delete | |
| run: git tag --points-at HEAD | xargs git tag --delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Each failed nightly build occurs right when new tag released and tag point to latest commit.
To avoid that, we need to drop tag to HEAD in CI
How can we test changes
masterhttps://github.com/MaxymVlasov/pre-commit-terraform-PR776/actions/runs/12916272093