Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding opened attribute #3731

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 10, 2025

Description

As the title. Aiming to improve XPL module stability.

Issue linked

Related to #3714

Checklist

@germa89 germa89 requested a review from a team as a code owner February 10, 2025 17:22
@germa89 germa89 self-assigned this Feb 10, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Feb 10, 2025
@germa89 germa89 force-pushed the feat/adding-opened-attribute-to-xpl-and-small-fixes branch from 04fedcc to a9ed1ec Compare February 10, 2025 17:26
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (78a5ebc) to head (a4621c0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3731      +/-   ##
==========================================
+ Coverage   88.06%   88.11%   +0.04%     
==========================================
  Files         187      187              
  Lines       14709    14717       +8     
==========================================
+ Hits        12954    12968      +14     
+ Misses       1755     1749       -6     

@germa89
Copy link
Collaborator Author

germa89 commented Feb 11, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 4e9fc46 into main Feb 11, 2025
51 checks passed
@germa89 germa89 deleted the feat/adding-opened-attribute-to-xpl-and-small-fixes branch February 11, 2025 12:54
germa89 added a commit that referenced this pull request Feb 14, 2025
* feat: adding opened attribute

* feat: adding opened attribute

* chore: adding changelog file 3731.miscellaneous.md [dependabot-skip]

* docs: adding docstring

* fix: tests

* fix: test

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants