Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ram units #3730

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix: ram units #3730

merged 3 commits into from
Feb 10, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 10, 2025

Description

Not assuming RAM in GB

Issue linked

Close #3724

Checklist

@germa89 germa89 requested a review from a team as a code owner February 10, 2025 15:40
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 10, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Feb 10, 2025

@pyansys-ci-bot LGTM.

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Feb 10, 2025
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 enabled auto-merge (squash) February 10, 2025 15:51
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (d2a4787) to head (2abfad8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3730      +/-   ##
==========================================
- Coverage   88.13%   88.06%   -0.08%     
==========================================
  Files         187      187              
  Lines       14707    14709       +2     
==========================================
- Hits        12962    12953       -9     
- Misses       1745     1756      +11     

@germa89 germa89 merged commit 78a5ebc into main Feb 10, 2025
43 of 47 checks passed
@germa89 germa89 deleted the fix/ram-not-in-mb branch February 10, 2025 16:32
germa89 added a commit that referenced this pull request Feb 14, 2025
* fix: ram units

* chore: adding changelog file 3730.fixed.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launch_mapdl - ram
2 participants