Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using cached version for remove lock on exit #3709

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 27, 2025

Description

To avoid raising issues when we are using the garbage collector and MAPDL is already dead.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner January 27, 2025 15:08
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 27, 2025
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.20%. Comparing base (a2f91e6) to head (941d6c0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3709      +/-   ##
==========================================
+ Coverage   87.88%   88.20%   +0.31%     
==========================================
  Files         187      187              
  Lines       14710    14716       +6     
==========================================
+ Hits        12928    12980      +52     
+ Misses       1782     1736      -46     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 27, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) January 27, 2025 17:27
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit ccc39fe into main Jan 27, 2025
46 of 49 checks passed
@germa89 germa89 deleted the feat/using-cached-version-for-remove-lock-on-exit branch January 27, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants