Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmetic changes #1483

Closed
wants to merge 1 commit into from
Closed

cosmetic changes #1483

wants to merge 1 commit into from

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Jan 8, 2025

No description provided.

manstis
manstis approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a read about use of "type": "module" and this PR LGTM 👍

@goneri goneri force-pushed the goneri/cosmetic-changes_2315 branch from b64b879 to 3ac288f Compare January 8, 2025 16:27
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@goneri
Copy link
Contributor Author

goneri commented Jan 8, 2025 •
edited
Loading

Had a read about use of "type": "module" and this PR LGTM 👍

Sorry, I actually pushed the PR by mistake. I was holding it because there is no clear PR description yet.

@goneri goneri closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manstis manstis manstis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @manstis