AAP-33915: Use the new exception handler for the Chat view #1478
Conversation
| segment_events[0]["properties"]["exception"], | ||
| "An exception <class 'ansible_ai_connect.ai.api.exceptions." | ||
| "ChatbotInvalidResponseException'> occurred during a chat generation", | ||
| segment_events[0]["properties"]["problem"], |
There was a problem hiding this comment.
This is a breaking change.
AACSAPIView uses Schema1Event.exception: bool to indicate whether an exception occurred. Schema1Event.problem contains the exception message. Is this going to cause Marty etc issues?
There was a problem hiding this comment.
I think so, well at least if he's using this field as for reports in Amplitude. Although this looks not a blocker, we just need to let him know in order to "refactor", if necessary, any query.
Also @manstis this is a good candidate to make the integration tests to fail :) I think we're doing assertions over this field, it worth checking too, IMO :)
There was a problem hiding this comment.
note: I knew the way we use this field is not always consistent depending on the view and I would like to converge to the new approach.
Feel free to object/cry/shout :-).
There was a problem hiding this comment.
oh @manstis , correct! Sorry for the confusion.
|
manstis
changed the title
Jira Issue: https://issues.redhat.com/browse/AAP-33915
Description
Internal refactoring of existing code.
Testing
N/A. Internal refactoring of existing code.
Steps to test
N/A. Internal refactoring of existing code.
Scenarios tested
N/A. Internal refactoring of existing code.
Production deployment