Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using quay.io/jameswong/git instead of alpine/git #1300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

using quay.io/jameswong/git instead of alpine/git #1300

wants to merge 1 commit into from
+1 −1

Conversation

jameswnl
Copy link
Contributor

https://issues.redhat.com/browse/AAP-29987

Description

alpine/git is being used in our Konflux pipeline but docker rate limit once a while will block access and fail our pipeline. Now switching to a clone in quay.io

Testing

Steps to test

  1. Pull down the PR
  2. ...
  3. ...

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

manstis
manstis previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Shame you have to use your jameswong organisation (should you leave Red Hat, revoke access, or whatever).

manstis
manstis approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manstis manstis manstis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameswnl @manstis