Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not include tsconfig files in npm archives #29282

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

devversion
Copy link
Member

rules_js includes tsconfig.json files in the DeclarationInfo provider. This ends up causing these files to be part of the npm archives.

`rules_js` includes `tsconfig.json` files in the `DeclarationInfo`
provider. This ends up causing these files to be part of the npm
archives.
@devversion devversion requested a review from alan-agius4 January 8, 2025 12:46
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 8, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 8, 2025
@alan-agius4 alan-agius4 merged commit 04b8184 into angular:main Jan 8, 2025
33 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants