Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): skip vite SSR warmup file configuration when SSR is disabled #29276

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

alan-agius4
Copy link
Collaborator

This change addresses recent updates in Vite that trigger pre-transform errors when SSR files (/server.mjs, /main.server.mjs) are missing. Skipping the configuration prevents unnecessary errors during the build process.

@alan-agius4 alan-agius4 requested a review from clydin January 8, 2025 10:24
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jan 8, 2025
… is disabled

This change addresses recent updates in Vite that trigger pre-transform errors when SSR files (`/server.mjs`, `/main.server.mjs`) are missing. Skipping the configuration prevents unnecessary errors during the build process.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2025
@alan-agius4 alan-agius4 merged commit 48cae81 into angular:main Jan 8, 2025
30 of 31 checks passed
@alan-agius4 alan-agius4 deleted the ssr-vite-warmup branch January 8, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants