feat(@angular/build): add ng-packagr builder to the package #29270
+195
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
|
Could this be called the library builder (@angular/build:library) instead? |
|
There will be a library builder in the future but it will effectively be a rewrite that will leverage the compilation internals of the application builder. |
Got it. Thanks for elaborating on this. |
clydin
added
the
action: review
alan-agius4
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM, just a couple of questions.
- Do you intend to remove the implementation from build-angular?
- Should we move the spec files?
- Should we export the builder from https://github.com/angular/angular-cli/blob/328854c99b706d78cbb0440102a71fe91eb3a481/packages/angular/build/src/index.ts?
alan-agius4
removed
the
action: review
clydin
force-pushed
the
ng-packagr-build-package
branch
2 times, most recently
from
e24994e to
b25747b
Compare
To support migration to the `@angular/build` package which contains the `application` builder that is used by all new projects, the `ng-packagr` builder used to build Angular libraries is also now available within this package. This removes the need for projects that are using the application builder but also would like to build a library from having to install the Webpack related `@angular-devkit/build-angular` package. This can result in a significant reduction in overall Node.js packages installed within the project.
…neration schematic The newly introduced `ng-packagr` builder within the `@angular/build` package is now used when generating a new library with `ng generate library`. This builder provides the same functionality as the `ng-packagr` builder found within the `@angular-devkit/build-angular` package but removes the need for projects to install `@angular-devkit/build-angular` if using the `application` builder from `@angular/build`.
…kagr builder package The `use-application-builder` update migration will now attempt to migrate the `ng-packagr` builder to use the `@angular/build` package if no other `@angular-devkit/build-angular` usage is present.
clydin
force-pushed
the
ng-packagr-build-package
branch
from
b25747b to
8b161bf
Compare
|
Is this ready to be merged for today's rc? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support migration to the
@angular/buildpackage which contains theapplicationbuilder that is used by all new projects, theng-packagrbuilder used to build Angular libraries is also now available within this
package. This removes the need for projects that are using the application
builder but also would like to build a library from having to install the
Webpack related
@angular-devkit/build-angularpackage. This can resultin a significant reduction in overall Node.js packages installed within the
project.