Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): add missing index option for the platform plugin #765

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Nov 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Which package are you modifying?

  • platform

What is the current behavior?

The nitro plugin inherits the platform options, but the interface doesn't reflect this as the index option was missing.

What is the new behavior?

You can see the index option in the options of the platform plugin

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit b111042
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/655ce2b3e3547e0008b4861e
😎 Deploy Preview https://deploy-preview-765--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit b111042
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/655ce2b31d892d0008bf433b
😎 Deploy Preview https://deploy-preview-765--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit b111042
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/655ce2b35fbae000088815ff
😎 Deploy Preview https://deploy-preview-765--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ocombe ocombe force-pushed the fix/platform-index-opt branch from b9947e1 to 682168a Compare November 21, 2023 16:52
@ocombe ocombe changed the title fix(platform): add missing index option for the nitro plugin fix(platform): add missing index option for the platform plugin Nov 21, 2023
@ocombe ocombe force-pushed the fix/platform-index-opt branch from 88643da to b111042 Compare November 21, 2023 17:02
@brandonroberts brandonroberts merged commit 9bd6609 into analogjs:main Nov 21, 2023
16 checks passed
@ocombe ocombe deleted the fix/platform-index-opt branch November 21, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants