Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro-angular): warn about shiki in mdx astro integration and override with prism #691

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

rlmestre
Copy link
Contributor

@rlmestre rlmestre commented Oct 4, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Documentation content changes

Which package are you modifying?

  • astro-angular

What is the current behavior?

Closes #690
Closes #653

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 7450af9
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/651d9badf37d46000867317b
😎 Deploy Preview https://deploy-preview-691--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 7450af9
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/651d9badd6783d0008964ec9
😎 Deploy Preview https://deploy-preview-691--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 7450af9
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/651d9bad67997a000724823a
😎 Deploy Preview https://deploy-preview-691--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 10ed7e5 into analogjs:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants