Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): only store valid HMR updates and clear on a full page reload #1550

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Jan 8, 2025

PR Checklist

Closes #

What is the new behavior?

  • Only store valid HMR updates from the compiler.
  • Correctly clears cache of HMR updates when full page reload is triggered, presenting app rendering inconsistencies.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 232f2fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/677ea25b83907b000894e141
😎 Deploy Preview https://deploy-preview-1550--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 232f2fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/677ea25bd9f0d20008185822
😎 Deploy Preview https://deploy-preview-1550--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 232f2fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/677ea25bda330900081847fe
😎 Deploy Preview https://deploy-preview-1550--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 232f2fb
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/677ea25bc226e10008bd39b7
😎 Deploy Preview https://deploy-preview-1550--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit aaa7d1a into beta Jan 8, 2025
24 checks passed
@brandonroberts brandonroberts deleted the fix-hmr-clear branch January 8, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant