fix(vite-plugin-angular): fix SSG and HMR of external component stylesheets #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlewis92
commented
Jan 7, 2025
| @@ -187,6 +188,33 @@ export function augmentHostWithResources( | |||
|
|
|||
| return null; | |||
| }; | |||
|
|
|||
| resourceHost.resourceNameToFileName = function ( | |||
There was a problem hiding this comment.
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattlewis92
force-pushed
the
fix-ssg-with-external-styles
branch
from
ecc0612 to
83b961f
Compare
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Brandon Roberts <[email protected]>
brandonroberts
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes #
What is the new behavior?
Fixes HMR of component
styleUrlswhen using SSG. Without this patch, all component stylesheet urls will be added to the DOM twice, and only the first one will be reloaded dynamically so the changes won't appear on the page.To test it locally, you can make a change in
apps/analog-app/src/app/pages/shipping/shipping.scssand observe HMR working onhttp://localhost:3000/shippingDoes this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?